Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize that mutiple scopes are allowed in Device flow parameters #24662

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Emphasize that mutiple scopes are allowed in Device flow parameters #24662

merged 8 commits into from
Mar 29, 2023

Conversation

0xTiger
Copy link
Contributor

@0xTiger 0xTiger commented Mar 24, 2023

Why:

In Step 1 of the Device Flow Section on the "Authorizing OAuth Apps" page it's not clear that mutiple scopes can be passed as the description reads "The scope that your app is requesting access to."

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

`scope` | `string` | The scope that your app is requesting access to.

->

`scope` | `string` | A space-delimited list of [scopes](/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps).

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Mar 24, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

barbarita1975

This comment was marked as spam.

ehsanhajipour5

This comment was marked as spam.

ehsanhajipour5

This comment was marked as spam.

@cmwilson21
Copy link
Contributor

@0xTiger Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Mar 27, 2023
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement! I made one minor suggestion that I will go ahead and incorporate, then we'll get this merged for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Mar 27, 2023
@cmwilson21 cmwilson21 enabled auto-merge March 28, 2023 14:36
@cmwilson21 cmwilson21 closed this Mar 29, 2023
auto-merge was automatically disabled March 29, 2023 21:09

Pull request was closed

@cmwilson21
Copy link
Contributor

Closing and reopening to try status checks again

@cmwilson21 cmwilson21 reopened this Mar 29, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 29, 2023
@cmwilson21 cmwilson21 enabled auto-merge March 29, 2023 21:11
@cmwilson21 cmwilson21 merged commit 631f732 into github:main Mar 29, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants