Skip to content

Fix Sentence Construction #23060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Fix Sentence Construction #23060

merged 6 commits into from
Jan 12, 2023

Conversation

Sriparno08
Copy link
Contributor

Why:

The below sentence is hard to understand:

Only pull request authors can give upstream repository maintainers, or those with push access to the upstream repository, permission to make commits to their pull request's compare branch in a user-owned fork.

Hence, I have decided to change the sentence construction to make it a bit easier to understand.

Closes #23021

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have changed the sentence to:

Screenshot 2023-01-08 115546

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@Sriparno08 Thanks for the PR! The original issue is still waiting for review, so once that happens, someone will review your PR based on the issue's review. ✨

In the mean time, please take a look at our help wanted section to find open issues you can work on. All items on this board have already been approved and have directions or a plan to get contributors started. 👍

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Jan 10, 2023
@Sriparno08
Copy link
Contributor Author

Alright, @cmwilson21 👍

@isaacmbrown
Copy link
Contributor

Hi @Sriparno08, thanks for the PR ✨ I think your proposal will clear up a lot of confusion with a small adjustment:

Although it wasn't very clear from the original wording, in this context upstream repository maintainer means anyone with push access to the upstream repository. Your proposal makes it sound like you can choose to give access either only to people with the maintainer role, or to anyone with push access to the upstream. If you look at the instructions on the page, you'll see that this level of granularity isn't available:

On user-owned forks, if you want to allow anyone with push access to the upstream repository to make changes to your pull request, select Allow edits from maintainers.

If you could edit your wording to make that clearer, I think this will be looking great! 🚀

@Sriparno08
Copy link
Contributor Author

Okay @isaacmbrown! Let me fix it!

@Sriparno08
Copy link
Contributor Author

Hey @isaacmbrown, I have made some changes. Have a look!

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md
@isaacmbrown
Copy link
Contributor

Hi @Sriparno08, looks good, thanks for making that change ✨

I just made a couple of changes with our style guide and translation workflow in mind. Otherwise this look good to go, and I'll add a label indicating that this can be merged 🚢

@isaacmbrown isaacmbrown added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 11, 2023
@Sriparno08
Copy link
Contributor Author

Thanks, @isaacmbrown 👍

@cmwilson21 cmwilson21 enabled auto-merge January 12, 2023 18:42
@cmwilson21 cmwilson21 merged commit 9138d04 into github:main Jan 12, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Sriparno08 Sriparno08 deleted the patch-1 branch January 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite sentence in "Allowing changes to a pull request branch created from a fork"
4 participants