-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Fix Sentence Construction #23060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sentence Construction #23060
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Sriparno08 Thanks for the PR! The original issue is still waiting for review, so once that happens, someone will review your PR based on the issue's review. ✨ In the mean time, please take a look at our help wanted section to find open issues you can work on. All items on this board have already been approved and have directions or a plan to get contributors started. 👍 |
Alright, @cmwilson21 👍 |
Hi @Sriparno08, thanks for the PR ✨ I think your proposal will clear up a lot of confusion with a small adjustment: Although it wasn't very clear from the original wording, in this context
If you could edit your wording to make that clearer, I think this will be looking great! 🚀 |
Okay @isaacmbrown! Let me fix it! |
Hey @isaacmbrown, I have made some changes. Have a look! |
...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md
Outdated
Show resolved
Hide resolved
…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md
Hi @Sriparno08, looks good, thanks for making that change ✨ I just made a couple of changes with our style guide and translation workflow in mind. Otherwise this look good to go, and I'll add a label indicating that this can be merged 🚢 |
Thanks, @isaacmbrown 👍 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The below sentence is hard to understand:
Hence, I have decided to change the sentence construction to make it a bit easier to understand.
Closes #23021
What's being changed (if available, include any code snippets, screenshots, or gifs):
I have changed the sentence to:
Check off the following: