Skip to content

change fromJson to fromJSON #22872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

change fromJson to fromJSON #22872

merged 2 commits into from
Jan 3, 2023

Conversation

kjarkur
Copy link
Contributor

@kjarkur kjarkur commented Dec 27, 2022 •
edited
Loading

change fromJson to fromJSON

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@kjarkur
make function names consistent
bb293c8 
change fromJson to fromJSON
@welcome
Copy link

welcome bot commented Dec 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 27, 2022
@kjarkur kjarkur changed the title make function names consistent change fromJson to fromJSON Dec 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/expressions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@kjarkur Thanks so much for opening a PR! I'll get this triaged for review ⚡

We appreciate your patience during the holiday season 💖

@cmwilson21 cmwilson21 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team account-and-profile Content relating to account and profile labels Dec 27, 2022
sophietheking
sophietheking approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjarkur 👋 Thank you so much for opening this PR and contributing to our Docs! This change looks good to me, I'll get the PR merged for you. 🚀

@sophietheking sophietheking removed the waiting for review Issue/PR is waiting for a writer's review label Jan 3, 2023
@jeanp1209
Copy link

jeanp1209 commented Jan 3, 2023 via email

@sophietheking sophietheking merged commit 62434c8 into github:main Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjarkur @cmwilson21 @jeanp1209 @sophietheking