-
Notifications
You must be signed in to change notification settings - Fork 64.4k
Adds missing {% raw %} tags to caching page
#22865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
Unfortunately, the example is actually re-using a code snippet that is embedded via LiquidJS tags, so disabling them wholesale is not the solution. |
|
Looks good to me; however, the section in question (which uses https://github.com/actions/gh-actions-cache/) shows up for ghes 3.7, when it probably shouldn't:
However, that seems to be an unrelated issue with a variable used in an |
|
@anno1985 Thank you for opening a PR and linking it to your issue! ✨ We appreciate all the info provided. 💖 I'll get this triaged for review ⚡ We appreciate your patience during the holiday season 💖 |
|
Hey @anno1985, thank you so much for opening this PR! Your updates look great. I'll go ahead and get this merged. 🚀 |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #22864
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adds missing
{% raw %}and{% endraw %}tags around three places with rendering issues in the last example on the caching page.These tags are currently missing, apparently causing the LiquidJS templating engine to attempt to parse GitHub Action expressions from that example and to render them as output. As the expressions aren't LiquidJS output tags, parsing fails, and nothing is rendered.
Check off the following:
For content changes, I have completed the self-review checklist.N/A: added tags only