Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shell injection in example #22826

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Remove shell injection in example #22826

merged 2 commits into from
Feb 15, 2023

Conversation

soliton-
Copy link
Contributor

Why:

Avoid shell injection in workflow example.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Workflow example

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 22, 2022
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 23, 2022
@cmwilson21
Copy link
Contributor

@soliton- Thanks so much for opening a PR! I'll get this triaged for review ⚡

@soliton-
Copy link
Contributor Author

@cmwilson21 Just a reminder. This probably got lost over the holidays. Is there anything I need to do?

@cmwilson21
Copy link
Contributor

@soliton- Thanks for checking in! It's up on the board waiting for review. Someone will have eyes on it soon. 👀

We do appreciate your patience as we are catching up after the holidays 💛

@cmwilson21 cmwilson21 added the SME reviewed An SME has reviewed this issue/PR label Feb 15, 2023
@cmwilson21
Copy link
Contributor

@soliton- Thanks again for your patience here! I checked with the team and this looks like a great addition to the docs. I'll get this merged down once all the tests have passed ✅

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Feb 15, 2023
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@cmwilson21 cmwilson21 enabled auto-merge February 15, 2023 15:41
@cmwilson21 cmwilson21 merged commit ca37c05 into github:main Feb 15, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@janl3577

This comment was marked as spam.

@soliton- soliton- deleted the patch-1 branch February 16, 2023 12:57
@hocnali963

This comment was marked as spam.

@hocnali963

This comment was marked as spam.

@Je-dev56

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants