Skip to content

fix-spelling-canceled #22692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2023
Merged

fix-spelling-canceled #22692

merged 4 commits into from
Jan 13, 2023

Conversation

technoph1le
Copy link
Contributor

@technoph1le technoph1le commented Dec 14, 2022

Why:

Closes #22624

What's being changed (if available, include any code snippets, screenshots, or gifs):

The word "cancelled" is changed to "canceled". However, the word inside the specific blocks, such as cancelled and <code>cancelled</code> has NOT been changed since they refer to GitHub Actions contexts or special functions.

The following files have been inspected and corrected according to the issue #22624

a list of changed files

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@technoph1le technoph1le requested a review from a team as a code owner December 14, 2022 15:55
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/troubleshooting/troubleshooting-creation-and-deletion-of-codespaces.md fpt
ghec
fpt
ghec
communities/maintaining-your-safety-on-github/blocking-a-user-from-your-organization.md fpt
ghec
fpt
ghec
communities/maintaining-your-safety-on-github/blocking-a-user-from-your-personal-account.md fpt
ghec
fpt
ghec
developers/github-marketplace/creating-apps-for-github-marketplace/viewing-transactions-for-your-listing.md fpt
ghec
fpt
ghec
developers/github-marketplace/selling-your-app-on-github-marketplace/pricing-plans-for-github-marketplace-apps.md fpt
ghec
fpt
ghec
developers/github-marketplace/using-the-github-marketplace-api-in-your-app/handling-plan-cancellations.md fpt
ghec
fpt
ghec
developers/github-marketplace/using-the-github-marketplace-api-in-your-app/testing-your-app.md fpt
ghec
fpt
ghec
organizations/managing-membership-in-your-organization/removing-a-member-from-your-organization.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
site-policy/github-terms/github-corporate-terms-of-service.md fpt
fpt
site-policy/github-terms/github-terms-of-service.md fpt
fpt
sponsors/receiving-sponsorships-through-github-sponsors/managing-your-sponsorship-tiers.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@dostonnabotov Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 16, 2022
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good to me. Thanks for raising this PR @dostonnabotov 👍

It's unfortunate that we use cancelled for actions, events, and as a status. However, when not referring to these directly, we should use the more common US English spelling of "canceled."

I'm holding off approving this for merging as we need to get the changes to the two site policy articles:
https://github.com/github/docs/pull/22692/files#diff-f47dd12027f2466c4965712e8121d44f6811d1c67cc5a6e169652c91de9a85f5
and
https://github.com/github/docs/pull/22692/files#diff-ffa23917e1ff7b5a569ab12289674191f4e21f65f1db6dcb4887f693e99a9835

reviewed and approved by someone from @github/site-policy-admins as these are legal documents and this spelling variant may be significant.

Copy link
Contributor

@literarytea literarytea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@technoph1le
Copy link
Contributor Author

Hi, @cmwilson21, @hubwriter.

Can I delete the branch fix-spelling-of-canceled-docs? Even though it shows that it has been merged, but the pull request is still open.

@hubwriter hubwriter merged commit de60219 into github:main Jan 13, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hubwriter
Copy link
Contributor

@dostonnabotov - Thanks for your patience.
Yes, you can delete that branch now.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Consistency for spelling of "canceled" in non-API docs
4 participants