-
Notifications
You must be signed in to change notification settings - Fork 62.2k
fix-spelling-canceled #22692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-spelling-canceled #22692
Conversation
@dostonnabotov Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all look good to me. Thanks for raising this PR @dostonnabotov 👍
It's unfortunate that we use cancelled
for actions, events, and as a status. However, when not referring to these directly, we should use the more common US English spelling of "canceled."
I'm holding off approving this for merging as we need to get the changes to the two site policy articles:
https://github.com/github/docs/pull/22692/files#diff-f47dd12027f2466c4965712e8121d44f6811d1c67cc5a6e169652c91de9a85f5
and
https://github.com/github/docs/pull/22692/files#diff-ffa23917e1ff7b5a569ab12289674191f4e21f65f1db6dcb4887f693e99a9835
reviewed and approved by someone from @github/site-policy-admins as these are legal documents and this spelling variant may be significant.
Awaiting review & approval by @github/site-policy-admins for these spelling changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi, @cmwilson21, @hubwriter. Can I delete the branch |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
@dostonnabotov - Thanks for your patience. |
Why:
Closes #22624
What's being changed (if available, include any code snippets, screenshots, or gifs):
The word "cancelled" is changed to "canceled". However, the word inside the specific blocks, such as
cancelled
and<code>cancelled</code>
has NOT been changed since they refer to GitHub Actions contexts or special functions.The following files have been inspected and corrected according to the issue #22624
Check off the following: