Skip to content

fix breadcrumbs block #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix breadcrumbs block #2251

merged 2 commits into from
Jan 5, 2021

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Dec 20, 2020

fix issue #2248

@Arhell Arhell marked this pull request as draft December 20, 2020 22:34
@janiceilene
Copy link
Contributor

Thanks for opening a PR @Arhell! I see that this is currently a draft, let me know when you're ready for it to be triaged for review 💖

@Arhell Arhell marked this pull request as ready for review December 21, 2020 23:10
@janiceilene janiceilene added the engineering Will involve Docs Engineering label Dec 22, 2020
@janiceilene
Copy link
Contributor

@Arhell Thanks for opening a PR! I'll get this triaged for review ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 29, 2020
@Arhell
Copy link
Contributor Author

Arhell commented Dec 29, 2020

update

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 30, 2020
heiskr
heiskr approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@heiskr heiskr merged commit e3425f2 into github:main Jan 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@Arhell Arhell deleted the fix-bread branch January 5, 2021 16:32
@mohdhairul
Copy link

Thanks to all my buddies to help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
engineering Will involve Docs Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @janiceilene @mohdhairul @heiskr