Skip to content

Uppercase first letter in nativeName #22487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Uppercase first letter in nativeName #22487

merged 5 commits into from
Dec 9, 2022

Conversation

dmitryburov
Copy link
Contributor

The language, that i changed, need show uppercase, how like other

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

/lib/languages.js - languages constant, ru block and nativeName parameter.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@dmitryburov dmitryburov requested a review from a team as a code owner December 6, 2022 07:06
@welcome
Copy link

welcome bot commented Dec 6, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 6, 2022
@dmitryburov dmitryburov changed the title Uppercase nativeName Uppercase first letter in nativeName Dec 6, 2022
@heiskr heiskr removed the request for review from a team December 6, 2022 16:24
@Octomerger Octomerger force-pushed the repo-sync branch 11 times, most recently from b95b541 to 4372c11 Compare December 8, 2022 19:39
@cmwilson21
Copy link
Contributor

@dmitryburov great catch! Thanks for spotting this and opening a PR ⚡

However, I noticed that this PR is trying to merge into our repo-sync as opposed to the main branch. Could you submit this PR against the main branch?

peterbe
peterbe previously approved these changes Dec 9, 2022
@peterbe peterbe changed the base branch from repo-sync to main December 9, 2022 12:58
@peterbe peterbe dismissed their stale review December 9, 2022 12:58

The base branch was changed.

@peterbe
Copy link
Contributor

peterbe commented Dec 9, 2022

@cmwilson21 I changed the target on this branch. And approved it. I don't know what your exact process is for landing things, but it looks good to me to go in now.

@m7mdxmeer

This comment was marked as spam.

@cmwilson21
Copy link
Contributor

@peterbe Thank you! I'll remember that option for next time. 😃 ✨

Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@cmwilson21
Copy link
Contributor

@dmitryburov Thanks for submitting this PR! I'll get it merged down once the checks have passed ✅

@cmwilson21 cmwilson21 added localization Issue or PR relating to translation or localization ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Dec 9, 2022
@cmwilson21 cmwilson21 enabled auto-merge December 9, 2022 15:37
@cmwilson21 cmwilson21 merged commit 361d806 into github:main Dec 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Issue or PR relating to translation or localization ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants