-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Uppercase first letter in nativeName #22487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
b95b541
to
4372c11
Compare
@dmitryburov great catch! Thanks for spotting this and opening a PR ⚡ However, I noticed that this PR is trying to merge into our |
@cmwilson21 I changed the target on this branch. And approved it. I don't know what your exact process is for landing things, but it looks good to me to go in now. |
This comment was marked as spam.
This comment was marked as spam.
@peterbe Thank you! I'll remember that option for next time. 😃 ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✨
@dmitryburov Thanks for submitting this PR! I'll get it merged down once the checks have passed ✅ |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The language, that i changed, need show uppercase, how like other
Why:
Closes ISSUE
What's being changed (if available, include any code snippets, screenshots, or gifs):
/lib/languages.js
- languages constant,ru
block andnativeName
parameter.Check off the following: