Skip to content

📝 remove HOME mention from Actions env var naming section #21444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022
Merged

📝 remove HOME mention from Actions env var naming section #21444

merged 2 commits into from
Oct 19, 2022

Conversation

wpbonelli
Copy link
Contributor

Why:

Closes #21424

What's being changed (if available, include any code snippets, screenshots, or gifs):

Remove mention of HOME environment variable from the naming conventions section of the Actions environment variables docs. Previously this was described as a "default" environment variable, which could be read to mean it is set by all runners/shells, despite being Unix-specific. (On Windows the corresponding variable is HOMEPATH.)

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 18, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/environment-variables.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @w-bonelli - Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 18, 2022
@sabrowning1 sabrowning1 changed the title 📝 remove HOME mention from Actions env var naming section 📝 remove HOME mention from Actions env var naming section Oct 18, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w-bonelli - many thanks for opening this pull request to update the docs following the discussion in the issue you opened 💖

This PR makes the change discussed in the issue and the preview looks good. 🚀

@felicitymay felicitymay enabled auto-merge (squash) October 19, 2022 07:51
@felicitymay felicitymay added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge labels Oct 19, 2022
@felicitymay felicitymay merged commit 1b9f0b9 into github:main Oct 19, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@wpbonelli wpbonelli deleted the develop branch October 19, 2022 12:57
@wpbonelli
Copy link
Contributor Author

@felicitymay no problem! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify $HOME environment variable in Actions docs
3 participants