Skip to content

Use ⌘ consistently #20843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use ⌘ consistently #20843

wants to merge 1 commit into from

Conversation

Zearin
Copy link
Contributor

@Zearin Zearin commented Sep 24, 2022

What's being changed (if available, include any code snippets, screenshots, or gifs):

Some Mac shortcuts used Command while others used

The symbol is well-known, shorter, and (to my eyes at least) “parses” easier than the reading the word “Command”.

So, might as well be consistent with it.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Sep 24, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 24, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/using-github/github-command-palette.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@HoneyBaby247

This comment was marked as resolved.

@HoneyBaby247

This comment was marked as resolved.

Copy link

@maharshi-sinha maharshi-sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you can also add (commands) in brackets too!

Copy link
Contributor

@AnilSeervi AnilSeervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these must to change to from Command.
The guidelines specifically instructs to use full words instead of symbols

@maharshi-sinha
Copy link

I don't think these must to change to from Command. The guidelines specifically instructs to use full words instead of symbols

My mistake! thanks for correcting me 👍

@cmwilson21
Copy link
Contributor

@Zearin Thanks for opening this PR! ✨

We appreciate the thought you put into this, but as @AnilSeervi pointed out in our guidelines, our practice is to use the full word "Command". If you see instances where that is not the case, feel free to open a PR for that fix!

I'm going to go ahead and close this PR. Thank you for interest and passion for improving the docs! 💛

@cmwilson21 cmwilson21 closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants