-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update adding-locally-hosted-code-to-github.md #19985
Conversation
This change is made to display a warning to reader that ``` -b main ``` flag does not older version of git.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@harsh8051 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything Alright
...r-projects-to-github/importing-source-code-to-github/adding-locally-hosted-code-to-github.md
Outdated
Show resolved
Hide resolved
...r-projects-to-github/importing-source-code-to-github/adding-locally-hosted-code-to-github.md
Outdated
Show resolved
Hide resolved
...r-projects-to-github/importing-source-code-to-github/adding-locally-hosted-code-to-github.md
Outdated
Show resolved
Hide resolved
Clarified how to do this step in Git 2.27.1 and earlier.
@harsh8051 Thank you so much for this excellent idea! 🎉 We've consulted the team and agree it will be very helpful to clarify that the steps apply to Git 2.28.0, as well as to add another method for Git 2.27.1 and below. We'll make those suggested wording changes and get this merged for you! |
Thank You @cmwilson21
|
Thank You @rohitverse
|
Thank You @meowius for considering my opinion
|
should I close this PR or have to wait ?
|
@harsh8051 We'll go ahead and merge it shortly! Was just double-checking on preview to make sure my commit had proper formatting. Thanks so much for checking. 💖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this excellent suggestion. Have changed the warning into inline copy since we were able to find a solution for those using older versions of Git.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
it's my pleasure mam. Thank you so much for your kind support
|
Thank you...I will definitely look for more contribution
|
Hello @meowius I think the reason is you can't rename branch without committing changes . As this document is about adding existing project to Github there will Untracked files . So we have to highlight this. Please consult with the team Try to initialize git repo and rename branch but failed
Add files to staging area and rename branch but failed
commit changes
Rename successful
Shall I open new issue for this or we can fix this by reopening this PL? |
Thanks so much @harsh8051, really appreciate your taking the time to flag this and provide this detail. I'll look into this and loop back. We can use this PR to track this work for now and then open a new PR when we have clarified the answer. Stay tuned! |
👋 Hi again @harsh8051 – Thank you again very much for pointing out the error, it's extremely thoughtful of you to try to prevent anyone else from frustration! Here's a new idea that we hope works, may I ask you to try it and see? In step 4 in the article, instead of:
Try:
Per our research this should be functional to even the oldest Git versions still in use, and it doesn’t require a commit to have been made. Would you be able to test and verify? If it does indeed work, it would be great to open a new PR. |
HI @meowius
Everything is fine. Branch Rename with untracked file |
Excellent @harsh8051, thank you so much for trying and verifying this solution! 🎉 Please let me know if you'd be willing to open a new PR to edit this article with the new solution, or if you'd prefer that we do so! |
Hi @meowius |
I understand @harsh8051! Thanks for being so thoughtful. I'll go ahead and open a PR in our internal repo to get this fixed! 💖 |
Just letting you know @harsh8051 that this is updated on production. Thank you again for your contributions! |
This change is made to display a warning to reader that
-b main
flag does not older version of git.Why:
Closes issue link
What's being changed
Add a warning block in adding-locally-hosted-code-to-github.md page
Check off the following:
Writer impact (This section is for GitHub staff members only):