Skip to content

Mention Body cannot be empty in Common validation errors when creating issue forms #19939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2022
Merged

Mention Body cannot be empty in Common validation errors when creating issue forms #19939

merged 6 commits into from
Aug 23, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 18, 2022 •
edited
Loading

Why:

Closes #17629

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding a section for Body cannot be empty.

image

Also including some yaml tags for some markdown blocks.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

jsoref added 2 commits August 17, 2022 23:47
@jsoref
Add yaml markers
c7e6dd1
@jsoref
Mention Body cannot be empty
089b6bc 
in `Common validation errors when creating issue forms`
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
communities/using-templates-to-encourage-useful-issues-and-pull-requests/common-validation-errors-when-creating-issue-forms.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@jsoref 👋 Thanks for opening a PR! I'll get this triaged for review 👀

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review communities Content related to Communities and removed triage Do not begin working on this issue until triaged by the team labels Aug 18, 2022
@sophietheking sophietheking self-requested a review August 23, 2022 08:37
@sophietheking
Copy link
Contributor

Hi @jsoref 👋 thanks for opening this PR, we really appreciate it! 💖

I made some small changes and it looks good to me! I'll get this merged for you. 🚀

@sophietheking sophietheking merged commit c252e1e into github:main Aug 23, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jsoref jsoref deleted the issue-17629 branch August 23, 2022 10:51
jsoref
jsoref commented Aug 23, 2022
View reviewed changes
...ourage-useful-issues-and-pull-requests/common-validation-errors-when-creating-issue-forms.md
@@ -629,6 +629,36 @@ body:
- Maybe
```

## Body cannot be empty

The template body `key:value` pair can not be empty. For more information about which top-level keys are required, see "[Syntax for issue forms](/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#top-level-syntax)."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't can not be cannot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
communities Content related to Communities content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention Body cannot be empty in Common validation errors when creating issue forms
3 participants
@jsoref @cmwilson21 @sophietheking