Skip to content

Conversation

bmorelli25
Copy link

@bmorelli25 bmorelli25 commented Jul 8, 2022

Why

I noticed an extra quotation mark in the example while reading the docs. Here's what the example looks like currently (before this PR)

Screen Shot 2022-07-08 at 2 57 08 PM

What's being changed

I've removed the extra quotation mark:

Screen Shot 2022-07-08 at 3 06 48 PM

Check off the following

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 8, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@cmwilson21
Copy link
Contributor

@bmorelli25 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Jul 11, 2022
@mchammer01 mchammer01 requested review from mchammer01 and removed request for mchammer01 July 12, 2022 06:45
@mchammer01 mchammer01 self-assigned this Jul 12, 2022
@mchammer01
Copy link
Contributor

mchammer01 commented Jul 12, 2022

@bmorelli25 👋🏻 - thanks for creating this PR ✨
The quotation mark is not a stray one, it closes the commit message (that starts after the -m flag in git commit -m "). I am therefore going to close this as the syntax is correct.

@mchammer01 mchammer01 closed this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants