-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links to community discussions #18887
Fix links to community discussions #18887
Conversation
62ed213
to
a56fde7
Compare
It seems like the links in feature preview are also broken. |
@nickmccurdy Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! JS changes look good, I manually tested too and things work as expected with the new URLs 👍
Can someone also please file an issue for internal links like in feature preview, or should I contact support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
…to-feedback-discussions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nickmccurdy 👋 thanks for opening this issue and fixing these links. Looks good to me!
I'll get this merged for you. 🚀
I noticed the repository got renamed. I'd like to update the links again before this is merged. |
@nickmccurdy Great catch on the rename! Thanks for bringing that up. This hasn't been merged yet, so if you want to go in and make those changes, feel free to do so. We would really appreciate it! 💛 |
Do I need to update the translations too? I noticed they're ignored in VSCode. |
Doing this again after merging to avoid force pushing
Unfortunately, we are not able to accept changes for translated content. Our translation process involves an integration with an external service, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we’re not there yet. |
Thank you so much for making these other updates! 💖 I'll get these merged down once the tests have been completed. 🍏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for taking the time to update this!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
I've noticed some newer docs are linking to https://github.com/orgs/community/discussions. Is there a difference? Should I update these to be more consistent? |
👋 Hey again @nickmccurdy. I spoke with the team and you are right. There's been several recent changes but the /orgs is the correct URL. Another great catch on your end. If you are still up for it, we would appreciate the update. |
What's being changed (if available, include any code snippets, screenshots, or gifs):
Community discussions have moved. This broke some links, so I fixed them.
Check off the following: