Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to community discussions #18887

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

nickserv
Copy link
Contributor

@nickserv nickserv commented Jun 30, 2022

What's being changed (if available, include any code snippets, screenshots, or gifs):

Community discussions have moved. This broke some links, so I fixed them.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/about-notifications.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
codespaces/the-githubdev-web-based-editor.md fpt
ghec
fpt
ghec
developers/webhooks-and-events/webhooks/webhook-events-and-payloads.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
discussions/collaborating-with-your-community-using-discussions/about-discussions.md fpt
ghec
ghes
fpt
ghec
ghes
education/explore-the-benefits-of-teaching-and-learning-with-github-education/use-github-in-your-classroom-and-research/about-github-education-for-educators-and-researchers.md fpt
fpt
get-started/using-github/github-mobile.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
packages/learn-github-packages/introduction-to-github-packages.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
repositories/releasing-projects-on-github/automatically-generated-release-notes.md fpt
ghec
ghes@ 3.6 3.5 3.4
fpt
ghec
ghes@ 3.6 3.5 3.4
repositories/working-with-files/using-files/working-with-non-code-files.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

@nickserv nickserv force-pushed the fix-links-to-feedback-discussions branch from 62ed213 to a56fde7 Compare June 30, 2022 05:27
@nickserv nickserv marked this pull request as ready for review June 30, 2022 05:29
@nickserv nickserv requested a review from a team as a code owner June 30, 2022 05:29
@nickserv
Copy link
Contributor Author

It seems like the links in feature preview are also broken.

@cmwilson21
Copy link
Contributor

@nickmccurdy Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 30, 2022
rsese
rsese previously approved these changes Jun 30, 2022
Copy link
Member

@rsese rsese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! JS changes look good, I manually tested too and things work as expected with the new URLs 👍

@nickserv
Copy link
Contributor Author

nickserv commented Jul 1, 2022

Can someone also please file an issue for internal links like in feature preview, or should I contact support?

Copy link

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@sophietheking sophietheking self-requested a review July 26, 2022 08:58
sophietheking
sophietheking previously approved these changes Jul 26, 2022
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickmccurdy 👋 thanks for opening this issue and fixing these links. Looks good to me!

I'll get this merged for you. 🚀

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jul 26, 2022
@nickserv
Copy link
Contributor Author

I noticed the repository got renamed. I'd like to update the links again before this is merged.

@cmwilson21
Copy link
Contributor

@nickmccurdy Great catch on the rename! Thanks for bringing that up. This hasn't been merged yet, so if you want to go in and make those changes, feel free to do so. We would really appreciate it! 💛

@cmwilson21 cmwilson21 added more-information-needed More information is needed to complete review and removed ready to merge This pull request is ready to merge labels Jul 27, 2022
@nickserv nickserv dismissed stale reviews from sophietheking and rsese via d6a886b July 27, 2022 21:36
@nickserv
Copy link
Contributor Author

Do I need to update the translations too? I noticed they're ignored in VSCode.

Doing this again after merging to avoid force pushing
@nickserv nickserv requested review from rsese and sophietheking July 27, 2022 22:29
@nickserv nickserv changed the title Fix links to feedback discussions Fix links to community discussions Jul 27, 2022
@cmwilson21
Copy link
Contributor

Unfortunately, we are not able to accept changes for translated content. Our translation process involves an integration with an external service, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we’re not there yet.

See https://github.com/github/docs/blob/main/contributing/types-of-contributions.md#earth_asia-translations.

@cmwilson21
Copy link
Contributor

Thank you so much for making these other updates! 💖

I'll get these merged down once the tests have been completed. 🍏

Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking the time to update this!

@cmwilson21 cmwilson21 merged commit 11e131b into github:main Jul 28, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@nickserv nickserv deleted the fix-links-to-feedback-discussions branch August 1, 2022 19:19
@nickserv
Copy link
Contributor Author

nickserv commented Aug 1, 2022

I've noticed some newer docs are linking to https://github.com/orgs/community/discussions. Is there a difference? Should I update these to be more consistent?

@cmwilson21
Copy link
Contributor

👋 Hey again @nickmccurdy. I spoke with the team and you are right. There's been several recent changes but the /orgs is the correct URL. Another great catch on your end. If you are still up for it, we would appreciate the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants