Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Terraform versions #18646

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Update supported Terraform versions #18646

merged 2 commits into from
Jun 28, 2022

Conversation

thispsj
Copy link
Contributor

@thispsj thispsj commented Jun 15, 2022

Why:

Closes #18491

What's being changed:

Updated the max supported Terraform version to 1.2.x

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 15, 2022
@janiceilene
Copy link
Contributor

@thispsj Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review dependabot Content related to Dependabot and removed triage Do not begin working on this issue until triaged by the team labels Jun 16, 2022
@felicitymay felicitymay added the needs SME This proposal needs review from a subject matter expert label Jun 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@felicitymay felicitymay removed the needs SME This proposal needs review from a subject matter expert label Jun 28, 2022
@felicitymay
Copy link
Contributor

My apologies, I added the needs SME label before clicking through to the issue 🤦🏻‍♀️

Thank you for opening this PR to fix the issue (which I can see has already been checked for technical accuracy) 💖

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thispsj - your change looks good. I'm just going to verify with the Dependabot team whether we can update this version number for GitHub Enterprise Server users too.

Then we'll either merge this PR as-is, or add a condition so that enterprise server users see the correct information.

@mchammer01
Copy link
Contributor

@thispsj - thanks for making this update ✨
Just checking with the Dependabot team whether we need to leave <= 1.0 for older GHES versions.
Will report back once I've heard from them.

@mchammer01 mchammer01 self-requested a review June 28, 2022 09:26
@mchammer01
Copy link
Contributor

I am going to merge this shortly. Our intent is that users will be able to pull in updated Dependabot actions in older GHES versions to get the latest Terraform versions.

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💖

@mchammer01 mchammer01 enabled auto-merge June 28, 2022 10:46
@mchammer01 mchammer01 merged commit f6e433b into github:main Jun 28, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@thispsj thispsj deleted the update-terraform-versions branch June 28, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dependabot Supported Versions of Terraform
4 participants