Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that there are two different auto-merge approaches #17773

Merged
merged 4 commits into from
May 13, 2022
Merged

clarify that there are two different auto-merge approaches #17773

merged 4 commits into from
May 13, 2022

Conversation

burnettk
Copy link
Contributor

@burnettk burnettk commented May 11, 2022 •
edited
Loading

one uses github actions and the other does not. this change, had it been in place, would have saved me some time.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@burnettk
clarify that there are two different approaches
1430a8e 
one uses github actions and the other does not.
@welcome
Copy link

welcome bot commented May 11, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md fpt
ghec
ghes@ 3.5 3.4 3.3
fpt
ghec
ghes@ 3.5 3.4 3.3

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels May 12, 2022
@ramyaparimi
Copy link
Contributor

@burnettk
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@mchammer01 mchammer01 self-requested a review May 13, 2022 12:52
mchammer01
mchammer01 reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnettk 👋🏻 - thanks for your contribution ✨
I've made an editorial suggestion to use variables. I'll apply it and then will approve this work 😃

mchammer01
mchammer01 approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💖

@mchammer01
Copy link
Contributor

mchammer01 commented May 13, 2022 •
edited
Loading

The staging preview doesn't seem to be working 😞
I'm going to merge this as the diff looks fine 🤞🏻

@mchammer01 mchammer01 merged commit 3b7de42 into github:main May 13, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burnettk @ramyaparimi @mchammer01