Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespaces write-all permission syntax is incorrect #17630

Merged
merged 4 commits into from
May 10, 2022
Merged

Codespaces write-all permission syntax is incorrect #17630

merged 4 commits into from
May 10, 2022

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented May 4, 2022

Codespaces write-all permission syntax is incorrect.

The current docs show invalid json

What's being changed:

"permissions": {
  "write-all"
 }

is invalid JSON.

It should be:

"permissions": "write-all"

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Codespaces `write-all` permission syntax is incorrect

The current docs show invalid json
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/managing-your-codespaces/managing-repository-access-for-your-codespaces.md fpt
ghec
fpt
ghec

reybard
reybard previously approved these changes May 4, 2022
jkeech
jkeech previously approved these changes May 4, 2022
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left one suggestion about a copy change directly above this that might be nice to tweak as well. ✨

@markphelps markphelps dismissed stale reviews from jkeech and reybard via b5bdb38 May 4, 2022 21:25
@markphelps markphelps requested review from jkeech and reybard May 4, 2022 21:27
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels May 5, 2022
@ramyaparimi
Copy link
Contributor

@markphelps
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markphelps - Many thanks for making this correction. 🎖️

@hubwriter hubwriter merged commit f289fcd into github:main May 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@markphelps markphelps deleted the patch-2 branch May 10, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants