Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic-writing-and-formatting: add raw=true also for images of same repo #17479

Merged

Conversation

phil-blain
Copy link
Contributor

It seems it is sometimes necessary to use the '?raw=true' parameter,
mentioned on the "In issues, pull requests and comments of another
repository" line of the table, even if the image linked to is in the
same repository as the issue or pull request.

Add it to the example in the line "In issues, pull requests and comments
of the repository" also.

…repo

It seems it is sometimes necessary to use the '?raw=true' parameter,
mentioned on the "In issues, pull requests and comments of another
repository" line of the table, even if the image linked to is in the
same repository as the issue or pull request.

Add it to the example in the line "In issues, pull requests and comments
of the repository" also.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels May 3, 2022
@ramyaparimi
Copy link
Contributor

@phil-blain
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@Marco071086

This comment was marked as spam.

@janiceilene janiceilene added the SME reviewed An SME has reviewed this issue/PR label Jun 2, 2022
Copy link
Contributor

@akenneth akenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for contributing to the docs! I'll get this merged once the tests have all passed.

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Jun 6, 2022
@cmwilson21 cmwilson21 merged commit 5e6556a into github:main Jun 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants