Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace API Slug with Secret type #17452

Merged
merged 4 commits into from
May 11, 2022
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 29, 2022

Why:

Closes #16825

What's being changed:

  • Replaces API Slug with Secret type
  • Adds some text to hint at where one can use a Secret type

image

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/secret-scanning/secret-scanning-patterns.md fpt
ghes@ 3.4 3.3 3.2 3.1
ghae
ghec
fpt
ghes@ 3.4 3.3 3.2 3.1
ghae
ghec

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Apr 29, 2022
@ramyaparimi
Copy link
Contributor

@jsoref
Thanks so much for opening a PR! I'll get this triaged for review ⚡

felicitymay
felicitymay previously approved these changes May 11, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoref - thank you for this PR. I'm going to make a small update to the link to help our translators, but otherwise this looks great :rocket.

@felicitymay felicitymay enabled auto-merge (squash) May 11, 2022 13:26
@felicitymay felicitymay added the ready to merge This pull request is ready to merge label May 11, 2022
@felicitymay felicitymay merged commit 6bb2c38 into github:main May 11, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the secret-types branch May 11, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API slug isn't defined in GHEC Secret scanning patterns page
3 participants