Skip to content

Remove incorrect statement re: permissions required to create PR from fork #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove incorrect statement re: permissions required to create PR from fork #17126

wants to merge 1 commit into from

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Apr 16, 2022

Why:

The content claims that write access is required to create a PR. This is incorrect. Only read access is required to create a PR.

What's being changed:

Remove incorrect statement.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

… fork

> Anyone with write access to a repository can create a pull request from a user-owned fork.

Write access is not required to create a PR.
@welcome
Copy link

welcome bot commented Apr 16, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 16, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.md Modified Original

@ramyaparimi ramyaparimi added pull requests Content related to pull requests content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 18, 2022
@ramyaparimi
Copy link
Contributor

@per1234
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @per1234, it is true that you cannot create a pull request unless you have write access to either the source branch or the target branch. This means you don't necessarily need write access to the repository you're creating the pull request in, but only if you do have write access to the fork you're creating the pull request from. Feel free to update this PR to clarify that in the permissions front matter, and to add back {% data reusables.pull_requests.perms-to-open-pull-request %}.

@per1234 per1234 mentioned this pull request Apr 18, 2022
@per1234
Copy link
Contributor Author

per1234 commented Apr 18, 2022

I have to disagree @lecoursen. Please tell me which of the two repositories I had the write permissions in that are supposedly required in order for me to submit #17172

@lecoursen
Copy link
Member

Thanks @per1234 for the demonstration. That's not the expected behavior here. You can report the bug to our support team.

@lecoursen lecoursen closed this Apr 18, 2022
@per1234
Copy link
Contributor Author

per1234 commented Apr 18, 2022

You can report the bug to our support team.

OK, I have done that.

I must say that I find this response disappointing from a security perspective. If this truly is a bug, then a user has produced a definitive demonstration of a significant misbehavior of one of GitHub's most security critical systems. If something equivalent occurred in one of the projects I am involved in, I would never dream of relying on the user following through to report something like that. Of course, it worked out fine in this particular case, but I know from experience that the average user would not have bothered in a situation like this where they are not impacted directly by the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants