-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Remove incorrect statement re: permissions required to create PR from fork #17126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… fork > Anyone with write access to a repository can create a pull request from a user-owned fork. Write access is not required to create a PR.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@per1234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 @per1234, it is true that you cannot create a pull request unless you have write access to either the source branch or the target branch. This means you don't necessarily need write access to the repository you're creating the pull request in, but only if you do have write access to the fork you're creating the pull request from. Feel free to update this PR to clarify that in the permissions front matter, and to add back {% data reusables.pull_requests.perms-to-open-pull-request %}
.
I have to disagree @lecoursen. Please tell me which of the two repositories I had the write permissions in that are supposedly required in order for me to submit #17172 |
Thanks @per1234 for the demonstration. That's not the expected behavior here. You can report the bug to our support team. |
OK, I have done that. I must say that I find this response disappointing from a security perspective. If this truly is a bug, then a user has produced a definitive demonstration of a significant misbehavior of one of GitHub's most security critical systems. If something equivalent occurred in one of the projects I am involved in, I would never dream of relying on the user following through to report something like that. Of course, it worked out fine in this particular case, but I know from experience that the average user would not have bothered in a situation like this where they are not impacted directly by the bug. |
Why:
The content claims that write access is required to create a PR. This is incorrect. Only read access is required to create a PR.
What's being changed:
Remove incorrect statement.
Check off the following:
Writer impact (This section is for GitHub staff members only):