Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean useless whitespaces in filter-branch example #1710

Merged
merged 2 commits into from
Dec 2, 2020
Merged

clean useless whitespaces in filter-branch example #1710

merged 2 commits into from
Dec 2, 2020

Conversation

maximd
Copy link
Contributor

@maximd maximd commented Dec 1, 2020 •
edited
Loading

Why: the double and trailing whitespaces are not needed in the git filter-branch example

What's being changed: remove the double whitespace and the trailing whitespace

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 1, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@maximd maximd marked this pull request as ready for review December 1, 2020 11:10
@janiceilene
Copy link
Contributor

@maximd Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 1, 2020
hubwriter
hubwriter approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximd - Good change 👍
Thanks for taking the time to correct this.

@hubwriter hubwriter merged commit b4082bc into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximd @janiceilene @hubwriter