Skip to content

Update index.md #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update index.md #1662

wants to merge 1 commit into from

Conversation

bnawingler
Copy link

Why:

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 28, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@SMAKSS SMAKSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the PR. Your current changes will break the page layout and finally will cause CI failing. So I guess those changes are unnecessary.

Also, for your future contributions keep in mind to fill out the PR template to let everyone know what is your change and why is it necessary to implement.

@janiceilene
Copy link
Contributor

This pull request is blank and appears have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
These experimental accessors have been added to work on both
time_weight and counter_agg aggregates in Toolkit 1.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants