Fixes output of wrong input variable in reusable #16283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`github.event.inputs.tag` is never set but `.tags` is. I changed the output text from singular to plural and changed the used input variable to the correct one
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
ramyaparimi
added
content
|
@SpraxDev |
ramyaparimi
added
the
needs SME
lucascosti
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Thanks heaps for this fix, @SpraxDev! 🚀
We're currently in the middle of a deployment freeze, but I will mark this as ready to be merged when the freeze is over.
lucascosti
added
ready to merge
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.event.inputs.tagis never set but.tagsis.I changed the output text from singular to plural and changed the used input variable to the correct one
Why:
Closes #16282
What's being changed:
I changed the job's output to use the correct input variable and reworded it from singular to plural.
Check off the following:
Writer impact (This section is for GitHub staff members only):