Skip to content

Refresh around dependencies #15750 #16190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

cmwilson21
Copy link
Contributor

Why:

Closes 15750

What's being changed:

Per recommendation - refreshed the phrasing around the first paragraph of the Dependencies View section. Also, created a list of conditions a repo must meet in order to display the "Used by" section.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 11, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/code-security/supply-chain-security/understanding-your-software-supply-chain/exploring-the-dependencies-of-a-repository.md Modified Original

@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Mar 14, 2022
@ramyaparimi
Copy link
Contributor

@cmwilson21
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@mchammer01 mchammer01 self-requested a review March 15, 2022 14:11
@mchammer01
Copy link
Contributor

I'll review this!

mchammer01
mchammer01 previously approved these changes Mar 15, 2022
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwilson21 - thanks for tackling this 💖
I've made a few suggestions, let me know if these aren't clear. Hope this helps 😃

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@mchammer01 mchammer01 enabled auto-merge March 17, 2022 15:44
@mchammer01 mchammer01 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 17, 2022
@mchammer01
Copy link
Contributor

Tried to merge this but there are two checks that are failing, one of which is a required test 😭

@mchammer01 mchammer01 merged commit ba4d739 into github:main Mar 17, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better explanation for "Used by" section
3 participants