Skip to content

Conversation

xty
Copy link
Contributor

@xty xty commented Mar 10, 2022

Corrected instructions for setting the GPG_TTY environment variables on GNU/Linux

Why:

The current instructions for setting GPG_TTY is unsuited for GNU/Linux. Unlike on macOS where interactive shells are also login shells, shells lauched by terminal emulators on GNU/Linux are non-login shells by default. As a result, neither .bash_profile nor .profile will be executed when they are started normally. See Bash Reference Manual for a fuller explanation.

What's being changed:

The relevant instructions have been updated to align with the standard practice of putting initialization commands in .bashrc on GNU/Linux. Please note that the GnuPG Manual also recommends that:

You should always add the following lines to your .bashrc or whatever initialization file is used for all shell invocations:

GPG_TTY=$(tty)
export GPG_TTY

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Mar 10, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md Modified Original

@xty xty force-pushed the export-GPG_TTY-instructions branch 3 times, most recently from 4117fc4 to 37018f2 Compare March 10, 2022 21:50
@xty xty force-pushed the export-GPG_TTY-instructions branch 2 times, most recently from 4ab2b7d to 349e524 Compare March 11, 2022 06:34
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 11, 2022
@ramyaparimi
Copy link
Contributor

@xty
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@xty xty force-pushed the export-GPG_TTY-instructions branch 2 times, most recently from a5797ee to f239724 Compare March 11, 2022 18:36
Corrected instructions for setting the GPG_TTY environment variables on GNU/Linux
@xty xty force-pushed the export-GPG_TTY-instructions branch from f239724 to f91402f Compare March 14, 2022 11:41
@vgrl vgrl self-assigned this Mar 29, 2022
vgrl
vgrl previously approved these changes Apr 3, 2022
Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution, thank you @xty !

One minor change to use the bash code block type instead of shell (we don't support the console type). I'll push this change and then the PR will be ready to merge 🎉 .

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in preview.

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Apr 3, 2022
@vgrl vgrl merged commit 1ed0ccc into github:main Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Copy link

@ALTURKA ALTURKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants