-
Notifications
You must be signed in to change notification settings - Fork 63.2k
Update telling-git-about-your-signing-key.md #16181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
4117fc4
to
37018f2
Compare
4ab2b7d
to
349e524
Compare
@xty |
a5797ee
to
f239724
Compare
Corrected instructions for setting the GPG_TTY environment variables on GNU/Linux
f239724
to
f91402f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great contribution, thank you @xty !
One minor change to use the bash
code block type instead of shell
(we don't support the console
type). I'll push this change and then the PR will be ready to merge 🎉 .
.../authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md
Outdated
Show resolved
Hide resolved
…telling-git-about-your-signing-key.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in preview.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of #
Corrected instructions for setting the
GPG_TTY
environment variables on GNU/LinuxWhy:
The current instructions for setting
GPG_TTY
is unsuited for GNU/Linux. Unlike on macOS where interactive shells are also login shells, shells lauched by terminal emulators on GNU/Linux are non-login shells by default. As a result, neither.bash_profile
nor.profile
will be executed when they are started normally. See Bash Reference Manual for a fuller explanation.What's being changed:
The relevant instructions have been updated to align with the standard practice of putting initialization commands in
.bashrc
on GNU/Linux. Please note that the GnuPG Manual also recommends that:Check off the following: