Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation fix: hyphen ➝︎ mdash #15858

Closed
wants to merge 1 commit into from
Closed

Conversation

jdaw1
Copy link

@jdaw1 jdaw1 commented Feb 25, 2022

Hyphen definitely wrong. Replaced with an mdash. If that not liked, a colon (“:”) could work, though the following capital letter should then be lower-cased.

Hyphen definitely wrong. Replaced with an mdash. If that not liked, a colon (“:”) could work, though the following capital letter should then be lower-cased.
@jdaw1 jdaw1 requested a review from a team as a code owner February 25, 2022 19:50
@welcome
Copy link

welcome bot commented Feb 25, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 25, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review site policy Content related to site policy and removed triage Do not begin working on this issue until triaged by the team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Feb 28, 2022
@ramyaparimi
Copy link
Contributor

@jdaw1
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene
Copy link
Contributor

@jdaw1 In the future, please fill out the pull request template in the top comment in this pull request.

We use - all throughout these docs and are not changing them to em dash, so I'm going to close this PR.

Thanks so much for your interest in improving the GitHub docs!

@janiceilene janiceilene closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team site policy Content related to site policy waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants