Github Actions Release Trigger | docs wrongly state that release-Action is triggered on draft #15839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My tests lead me to the assumption, that the `released`-action is only triggered when a release is done (either directly or by finishing a draft). The docs say, `release` is also triggered when a release-draft is published. But IMO this isn't the case. And it wouldn't make sense with an action called `release`, as a draft is NOT a release.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
ramyaparimi
added
actions
|
@kohlerdominik |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
lucascosti
approved these changes
Apr 4, 2022
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
My tests lead me to the assumption, that the
released-action is only triggered when a release is done (either directly or by finishing a draft).The docs say,
releaseis also triggered when a release-draft is published. But IMO this isn't the case. And it wouldn't make sense with an action calledrelease, as a draft is NOT a release.What's being changed:
The docs state, that a Webhook with the
action=releasedis triggered, when a draft is published.But IMO this is neither the case, nor would it make sense regarding the naming. A draft is NOT a release.
Check off the following: