Update Windows default shell

[al-cheb]

Why:

Windows default shell is incorrect.

jobs:
  build:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
       os: [windows-2016, windows-2019]
    steps:
    - name: Default shell ${{matrix.os}}
      run: $PSVersionTable.PSEdition
    - name: PowerShell Desktop ${{matrix.os}}
      shell: powershell
      run: $PSVersionTable.PSEdition

Windows Server 2016:

Windows Server 2019:

What's being changed:

Set the default shell is pwsh for Windows.

Check off the following:

• All of the tests are passing.
• I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
• For content changes, I have reviewed the localization checklist
• For content changes, I have reviewed the Content style guide for GitHub Docs.

A rendered preview of these changes is available here: https://docs-1558--al-chebwindows-defa.herokuapp.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[janiceilene]

@al-cheb Thanks so much for opening a PR! I'll get this triaged for review 🌟

[shati-patel]

(For information: I just updated this PR from main to fix a merge conflict that came from #1389. I'll let someone from the Ecosystem docs team take a look at the actual changes, since they're more familiar with these topics!)

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[janiceilene]

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

[martin389]

A rendered preview of these changes is available here: https://docs-1558--al-chebwindows-defa.herokuapp.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[martin389]

Status update: Checking these changes with our support folks

[moneyglitxh]

?

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[al-cheb]

@martin389, Thank you.

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[martin389]

Status update: Following up with support folks ✨

[maxim-lobanov]

This is absolutely correct for Hosted runners but I have small note about self-hosted:
If self-hosted Windows runner doesn't have PowerShell Core installed, default shell falls back to PowerShell Desktop.
Related code: https://github.com/actions/runner/blob/main/src/Runner.Worker/Handlers/ScriptHandler.cs#L87

@martin389, do you think it should be mentioned?

[martin389]

Thanks @maxim-lobanov, makes sense to me 👍 I'll add a note to mention this.

[github-actions]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

[martin389]

Thank you for this PR! Changes will be visible here once published: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell