Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove starter workflows from code examples #1392

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

andymckay
Copy link
Contributor

@andymckay andymckay commented Nov 16, 2020

Why:

👋🏾 This PR removes starter workflows from code examples on the docs page (I think). The workflows are all visible when a user hits the Actions tab and starts a new workflow. But on the way we do a transformation for example $default-branch to whatever your default branch is. So they don't work too well.

Some of the other things in the actions org might work, although not sure they qualify as good examples for learning from.

What's being changed:

image (17)

Check off the following:

👋🏾 This PR removes starter workflows from code examples on the docs page (I think). The workflows are all visible when a user hits the Actions tab and starts a new workflow. But on the way we do a transformation for example `$default-branch` to whatever your default branch is. So they don't work too well.

Some of the other things in the actions org might work, although not sure they qualify as good examples for learning from.
@welcome
Copy link

welcome bot commented Nov 16, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 17, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 25, 2020
@andymckay
Copy link
Contributor Author

Please don't close stale 😄

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 6, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 7, 2020
@martin389
Copy link
Contributor

I've let docs engineering know about this PR 👍

@simpsoka
Copy link
Contributor

simpsoka commented Dec 8, 2020

Thanks @andymckay! I'm 👍 on this one.

@janiceilene janiceilene added engineering Will involve Docs Engineering and removed actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 8, 2020
Copy link
Member

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andymckay! We'll get this merged in the next few days after GitHub Universe (shameless plug). :octocat:

@JamesMGreene JamesMGreene merged commit 0c8f74f into main Dec 9, 2020
@JamesMGreene JamesMGreene deleted the remove-starter-workflow branch December 9, 2020 22:35
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

This was referenced Jan 18, 2022
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants