Skip to content

Restructure sentence to include .NET Framework #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Restructure sentence to include .NET Framework #1330

merged 2 commits into from
Nov 17, 2020

Conversation

Perkles
Copy link
Contributor

@Perkles Perkles commented Nov 14, 2020

Why:

Restructure a sentence to include .NET Framework as one of the examples as instructed #1308

What's being changed:

Updates finding-security-vulnerabilities-and-errors-in-your-code/troubleshooting-the-codeql-workflow.md

In step 5 of the "No code found during the build" section, the following statement can also apply to .NET Framework projects:

For C# projects using either dotnet build or msbuild which target .NET Core 2, you should specify /p:UseSharedCompilation=false in your workflow's run step, when you build your code. The UseSharedCompilation flag isn't necessary for .NET Core 3.0 and later.

Change this to:

For .NET Framework projects, and for C# projects using either dotnet build or msbuild that target .NET Core 2, you should specify /p:UseSharedCompilation=false in your workflow's run step, when you build your code. The UseSharedCompilation flag isn't necessary for .NET Core 3.0 and later.

Check off the following:

@welcome
Copy link

welcome bot commented Nov 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@Perkles Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team DSP labels Nov 16, 2020
@shati-patel shati-patel self-assigned this Nov 17, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, @Perkles! 😃
I'll get this PR merged once all the tests pass ✔️

@shati-patel shati-patel merged commit 8c1241b into github:main Nov 17, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update troubleshooting topic: UseSharedCompilation also applies to .NET Framework projects
3 participants