Skip to content

Increasing the importance #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2020
Merged

Increasing the importance #1271

merged 4 commits into from
Dec 2, 2020

Conversation

Aakarsh-B
Copy link
Contributor

@Aakarsh-B Aakarsh-B commented Nov 12, 2020 •
edited
Loading

Why:

I wanted to delete a branch from a repository of mine, but I couldn't in spite of reading this document. The problem was, the branch I wanted to delete was the default branch. I had to google to find the answer even though it was right here in the document.
Even though it is stated in this document, it was not given enough importance that everyone would see it.

What's being changed:

There is not much change. A line has been made bold using 4 '#'.
This was done to ensure people who aren't familiar with deleting branches notices this.

Check off the following:

@Aakarsh-B
Increasing the importance
ac3a5a1 
I wanted to delete a branch, but I couldn't in spite of reading this document. The problem was, the branch I wanted to delete was the default branch. 
Even though it is stated in this document, it was not given enough importance that everyone would see it.
@welcome
Copy link

welcome bot commented Nov 12, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@Aakarsh-B Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 13, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 21, 2020
@Aakarsh-B
Copy link
Contributor Author

Commenting cause the bot asked me to.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 23, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience @Aakarsh-B! This is definitely not stale 💖

@Aakarsh-B
Copy link
Contributor Author

Thanks for your patience @Aakarsh-B! This is definitely not stale 💖

Thank you

felicitymay
felicitymay requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Aakarsh-B 👋🏻

Thanks for raising this PR and suggesting that we make this paragraph more prominent. That sounds like a good solution to avoid other people missing this information.

I've added a suggestion to highlight this text in a different way so that it's consistent with the rest of the docs and inline with our style guide.

Aakarsh-B and others added 2 commits December 2, 2020 20:44
@Aakarsh-B @felicitymay
Update content/github/collaborating-with-issues-and-pull-requests/cre…
917b188 
…ating-and-deleting-branches-within-your-repository.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
@Aakarsh-B
Merge branch 'main' into patch-1
141f0ce
Aakarsh-B
Aakarsh-B commented Dec 2, 2020
View reviewed changes
Copy link
Contributor Author

@Aakarsh-B Aakarsh-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than my approach.

felicitymay
felicitymay approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again for raising this problem and showing a way to improve the docs.

This is ready to merge.

@felicitymay felicitymay merged commit 06ad687 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Octomerger pushed a commit that referenced this pull request Nov 30, 2021
aggressive cache-control on archived redirects (#23091)
5c2777a 
Part of #1271
Octomerger pushed a commit that referenced this pull request Dec 3, 2021
24h cache all internal redirects without language prefix (#23354)
ddd1447 
Part of #1271
Octomerger added a commit that referenced this pull request Dec 9, 2021
@heiskr @roferg
@jmarlena @docubot @francisfuzz @Octomerger
301 redirects should not set-cookie (#23360)
77f298f 
* 301 redirects should not set-cookie

Part of #1316

* Update release-notes.js

* No public facing doc changes (#23355)

Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>

* New translation batch for pt (#23362)

* Add crowdin translations

* Run script/i18n/homogenize-frontmatter.js

* Run script/i18n/fix-translation-errors.js

* Run script/i18n/lint-translation-files.js --check parsing

* Run script/i18n/lint-translation-files.js --check rendering

* run script/i18n/reset-known-broken-translation-files.js

* Check in pt CSV report

* 24h cache all internal redirects without language prefix (#23354)

Part of #1271

* Redirects for root path should not set-cookie in all supported languages (#23377)

* test: add case when unsupported language is specified in redirect

* test: assert root redirects to appropriate language preference if specified

* refactor: remove redundant unit test

* refactor: re-order units starting with affirmative case

* refactor: remove single-use variable from unit

* fix: re-include previous unit with udpated description

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Rogan Ferguson <40493721+roferg@users.noreply.github.com>
Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@ggodeke @charislam @Loquacity
Grant/new ha docs (github#1271)
7c3a79d 
Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Mar 22, 2024
Open
@RanaAhmed2020 RanaAhmed2020 mentioned this pull request Mar 22, 2024
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Mar 22, 2024
Open
@aliscco aliscco mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aakarsh-B @janiceilene @felicitymay