Skip to content

doc: update docs for publishing to npm + gpr #12553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2021
Merged

doc: update docs for publishing to npm + gpr #12553

merged 7 commits into from
Dec 8, 2021

Conversation

MylesBorins
Copy link
Contributor

  • Updated copy to clarify some points
  • Updated version of Node.js used in setup node
  • Removed section on dual publish as it is not an ideal or suggested workflow

@MylesBorins
doc: update docs for publishing to npm + gpr
92beefd 
* Updated copy to clarify some points
* Updated version of Node.js used in setup node
* Removed section on dual publish as it is not an ideal or suggested workflow
@welcome
Copy link

welcome bot commented Dec 1, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/publishing-packages/publishing-nodejs-packages.md Modified Original

ethomson
ethomson reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@ethomson ethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the yarn example to use a more modern Node.js as well?

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 1, 2021
ejcheng
ejcheng reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skedwards88
skedwards88 reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thank you for improving these examples! I just have one clarifying question.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Dec 8, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Dec 8, 2021
@skedwards88 skedwards88 enabled auto-merge (squash) December 8, 2021 00:04
@skedwards88 skedwards88 merged commit 3aad784 into github:main Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson left review comments

@ejcheng ejcheng ejcheng left review comments

@yasminazaze yasminazaze yasminazaze left review comments

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @ethomson @skedwards88 @ejcheng @yasminazaze @ramyaparimi