Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] force push #1230

Merged
merged 4 commits into from
Dec 11, 2020
Merged

[add] force push #1230

merged 4 commits into from
Dec 11, 2020

Conversation

sassbalint
Copy link
Contributor

Why:

I think the force push step is missing at the end of Using the BFG section.

What's being changed:

One line added: do the force push.

Check off the following:

@welcome
Copy link

welcome bot commented Nov 10, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @sassbalint! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 10, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 18, 2020
@sassbalint
Copy link
Contributor Author

Thanks so much for opening a PR @sassbalint! I'll get this triaged for review zap

Sorry, am I expected to contribute something? :)

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 19, 2020
@janiceilene
Copy link
Contributor

@sassbalint Thanks for your patience! Our small team is working through lots of reviews and there's nothing else you need to do right now 💛 We'll review this soon and suggest changes or get it merged!

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 27, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 30, 2020
lecoursen
lecoursen reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sassbalint! I left a suggested change and will merge this PR as soon as you apply it! 🎉

content/github/authenticating-to-github/removing-sensitive-data-from-a-repository.md Outdated Show resolved Hide resolved
@lecoursen lecoursen merged commit 6e3b9e9 into github:main Dec 11, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@snyk-bot snyk-bot mentioned this pull request Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sassbalint @janiceilene @lecoursen