Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo sync #11609

Merged
merged 15 commits into from
Nov 2, 2021
Merged

repo sync #11609

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6b3be30
add `data` directory (#22529)
becco Nov 2, 2021
c8899a4
Merge branch 'main' into repo-sync
Octomerger Nov 2, 2021
47ae46c
Merge pull request #22531 from github/repo-sync
Octomerger Nov 2, 2021
d7a4e93
Document 3-level restriction for workflow_run (#22508)
hubwriter Nov 2, 2021
ad0af33
Fix broken link for GHAE-only page (#22509)
hubwriter Nov 2, 2021
dca7e56
More hydro error info (#22533)
heiskr Nov 2, 2021
a147879
Only interested in current version's guides (#22535)
rsese Nov 2, 2021
9c559bb
update search indexes
actions-user Nov 2, 2021
2eb1afb
Update enabling-github-packages-with-minio.md (#22538)
Nov 2, 2021
d6d40a9
500 on /en/enterprise-server@2.16/admin (#22532)
heiskr Nov 2, 2021
17c2df4
Workflow to transfer localization issues to localization repo (#21857)
ramyaparimi Nov 2, 2021
b211776
Updating to scroll past header notifications and keep header sticky (…
gracepark Nov 2, 2021
5687df3
Adds documentation for GHEC user dormancy reporting (#22029)
emmaviolet Nov 2, 2021
6747838
fix: update staging-deploy-pr to never untar artifact from public rep…
mikesurowiec Nov 2, 2021
2969394
have header span the entire page (#22543)
gracepark Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
500 on /en/enterprise-server@2.16/admin (#22532) 
* 500 on /en/enterprise-server@2.16/admin

* Update release-notes.js
  • Loading branch information
@heiskr
heiskr authored Nov 2, 2021
commit d6d40a974ea905592c9c56c94b8d98979eaa50be
3 changes: 2 additions & 1 deletion middleware/contextualizers/release-notes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export default async function releaseNotesContext(req, res, next) {
if (!(req.pagePath.endsWith('/release-notes') || req.pagePath.endsWith('/admin'))) return next()

const [requestedPlan, requestedRelease] = req.context.currentVersion.split('@')

const releaseNotesPerPlan = req.context.site.data['release-notes'][requestedPlan]

// Release notes handling differs if version has numbered releases (like GHES) or not (like GHAE)
Expand All @@ -33,7 +34,7 @@ export default async function releaseNotesContext(req, res, next) {
if (hasNumberedReleases) {
const currentReleaseNotes = releaseNotesPerPlan[`${requestedRelease.replace(/\./g, '-')}`]

if (!currentReleaseNotes && req.pagePath.endsWith('/release-notes')) {
if (!currentReleaseNotes) {
// If the GHES version doesn't have any release notes, let's be helpful and redirect to `enterprise.github.com`
return requestedPlan === 'enterprise-server'
? res.redirect(`https://enterprise.github.com/releases/${requestedRelease}.0/notes`)
Expand Down