Skip to content

Update managing-a-custom-domain-for-your-github-pages-site.md #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

gaoyaoxin
Copy link
Contributor

@gaoyaoxin gaoyaoxin commented Nov 5, 2020

Why:

#1099

What's being changed:

dot

Check off the following:

@welcome
Copy link

welcome bot commented Nov 5, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mchammer01
Copy link
Contributor

Hi @gaoyaoxin 👋🏻 - thanks for spotting this typo ✨

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for helping us improve our docs 🙂
LGTM ⚡

@mchammer01 mchammer01 merged commit 7765cba into github:main Nov 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* link fixes and procedure tag fixes

* Update promscale/visualize-data/apm-experience.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* incorporated Lana's suggestion

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants