-
Notifications
You must be signed in to change notification settings - Fork 62k
chore: Add EditorConfig for IDE whitespace #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @nschonni! I'll get this triaged for review ✨ |
@nschonni just confirming, this |
Yes, the whitespace settings are picked up, so when you hit the Tab key, it inserts the indicated number of spaces, and will add the EOF marker if it is missing. {
"recommendations": ["EditorConfig.EditorConfig"]
} Didn't add that in this PR to keep the discussion focused, but I can add that in if you want. It looks like I had taken a quick look at what flipping to plain ESLint + Prettier would look like, but it reformatted so much I didn't want to submit it out of the blue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for the addition @nschonni! If I was going to write a .editorconfig
file, this is exactly what I'd write 📝 I'll leave it to @chiedo or @janiceilene to actually merge this once they're ready, but 👍 from an eng perspective. ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
Allows IDEs and GitHub web editor to detect the whitespace settings when editing files https://editorconfig.org/
What's being changed:
Add a basic .editorconfig file, but don't run any normalizaton
Check off the following: