Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Adding a new page to your site" section missing critical last steps #2150

Closed
logankilpatrick opened this issue Dec 16, 2020 · 3 comments · Fixed by #6667
Closed

"Adding a new page to your site" section missing critical last steps #2150

logankilpatrick opened this issue Dec 16, 2020 · 3 comments · Fixed by #6667
Assignees
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@logankilpatrick
Copy link
Contributor

What article on docs.github.com is affected?

https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/adding-content-to-your-github-pages-site-using-jekyll#adding-a-new-page-to-your-site

and

https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/adding-content-to-your-github-pages-site-using-jekyll#adding-a-new-post-to-your-site

What part(s) of the article would you like to see updated?

Right now, the last step is to open the Pull Request. This will NOT actually update the person's site. There should be additional steps to review the PR and then merge it in so that the content becomes part of the repo.

Additional information

Inspired by this thread: https://github.community/t/issues-adding-a-new-page/150201

CC @AndreaGriffiths11

@welcome
Copy link

welcome bot commented Dec 16, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 16, 2020
@janiceilene
Copy link
Contributor

@logankilpatrick Thanks for opening an issue! I'll get this triaged for the right team to take a look 👀

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core and removed triage Do not begin working on this issue until triaged by the team labels Dec 16, 2020
@AlexandraMMR
Copy link
Contributor

@emilyistoofunky I'll take this one next! 😁 I might have a few questions, will let you know!

AlexandraMMR added a commit to AlexandraMMR/docs that referenced this issue May 22, 2021
Updated the page based on request from Issue github#2150 and created new reusables for the additional steps to complete the PR.
ethanpalm added a commit that referenced this issue May 27, 2021
Alexandrammr - Adding steps in instructions for #2150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Development

Successfully merging a pull request may close this issue.

3 participants