Move lib/*.js files used only in tests to tests/lib (or something)

[JasonEtco]

While reviewing github/docs-internal#15734, I had a difficult time grokking which code was used during runtime vs. only in tests/local scripts. I've thought that a couple of times - we don't currently have a clear separation of that code. Generally speaking, lib is used for runtime code - stuff to run the server. Code solely used for tests often lives in like a tests/helpers directory or something.

Interested in how y'all feel @github/docs-engineering, if this is just me or if others have felt this confusion as well.

[zeke]

Keeping test utils in their own directory in /tests/something sounds good to me.

Do you have any examples of this?

[sarahs]

The two I can think of are lib/check-images.js and lib/check-links.js. I agree those can live in the test dir. 👍

There is also lib/remove-liquid-statements.js, which we don't use in runtime code, but we use it in scripts as well as tests. So lib seems OK for that one since it's used in multiple places.

Are there others you noticed, @JasonEtco?

[JamesMGreene]

NOTE: With this, we should also review which of are Node dependencies are actually devDependencies that should be moved in the package.json.

[github-actions]

This issue is stale because it has been open 60 days with no activity.