Skip to content

Doesn't output all contributors #392

@nikelborm

Description

@nikelborm

Describe the bug

Not all commits/PRs are shown in rendered discussions.

Example of broken behavior №1

MDN GitHub org discussion #861: Thank you contributors! (Nov 25)

I'm absent there, although I've contributed in November.

Links showing my (@nikelborm) contributions:

Example of broken behavior №2

MDN GitHub org discussion #865: Thank you contributors! (Dec 25)

I'm absent there, although I've contributed in December.

Links showing my (@nikelborm) contributions:

Example of finally working behavior

MDN GitHub org discussion #867: Thank you contributors! (Jan 26)

I'm present there, and I contributed in January.

Links showing my (@nikelborm) contributions:

To Reproduce

Source code of MDN's GitHub Action workflow (contributors.yml), which renders these discussions

Runs of that workflow (contributors.yml)

Expected behavior

Contributions are shown for all people who have contributed in that month

Additional context

I'm not posting this because I'm upset that my contributions were not acknowledged. I'm posting this because many other people might not have been acknowledged as well.

And I understand the bug might have been fixed, hence it's finally started to render me, but it might not be, and the fact I finally appeared may just be flaky luck.

My hypotheses of these flaky situations:

  1. Me, who happened to be on the last pages of pagination, and the initial script fetches only the first N
  2. The script that fetches pages with data improperly handles failures, such as Rate limiting or other issues, and just silently continues without failing early or retrying.
  3. Too slow indexing of PRs in the search API (seems unlikely)
  4. Some problems related to the introduction of semantic search on GitHub
  5. The script doesn't render contributors who have only committed one PR/commit in a month

This issue's discussion in MDN org #868

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions