Reword Security Consideration for using a GitHub App#65
Open
dgholz wants to merge 1 commit intogithub:mainfrom
Open
Reword Security Consideration for using a GitHub App#65dgholz wants to merge 1 commit intogithub:mainfrom
dgholz wants to merge 1 commit intogithub:mainfrom
Conversation
I reworded the section to be more imperative: describe what the user should do to improve the security. And described what privileged access the GitHub App would have (and why), and the potential security concerns. I also summarised the argument against using separate private keys for the GitHub App to just say 'GitHub App credentials can be used on any repo'. And dropped the mention of fine-grained tokens, as GitHub Apps don't support them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reworded the section to be more imperative: describe what the user should do to improve the security. And described what privileged access the GitHub App would have (and why), and the potential security concerns.
I also summarised the argument against using separate private keys for the GitHub App to just say 'GitHub App credentials can be used on any repo'. And dropped the mention of fine-grained tokens, as GitHub Apps don't support them.