Skip to content

Fix invalid devcontainer.json - #7

Merged
joshaber merged 1 commit into
github:mainfrom
Chuxel:patch-1
Nov 17, 2022
Merged

Fix invalid devcontainer.json#7
joshaber merged 1 commit into
github:mainfrom
Chuxel:patch-1

Conversation

@Chuxel

@Chuxel Chuxel commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

A number of these templates are missing an image reference, which means they won't work anywhere outside of Codespaces, including in the Dev Container GitHub Action.

If the goal is to use the "kitchen sink" image, all that is needed is a reference to the image. This will be slow in other scenarios, but won't fail like it would today.

@joshaber
joshaber merged commit 3a9e8cb into github:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants