Draft/brave volhard #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base: main Head repository: salehah737/groceries-project Compare: feature/search
git tag -a v0.2.0 -m "Frontend implementation release"
- Backend Django implementation - Frontend React with TypeScript - Complete grocery e-commerce functionality"
Feature/search
Crypto-Sanemi
pushed a commit
to Crypto-Sanemi/codespaces-blank
that referenced
this pull request
Jun 20, 2025
…e conditions (github#87) This PR moves the finalize checks to a function that can run incrementally as we poll for new orders such that batch deadlines can be detected and finalized without new orders coming into the aggregator to trigger it. It also adds a config option for how often to the aggregator should check for new proofs to aggregate / finalize checks. Additionally it adds a unit test for batch-deadline detection. This PR does increase the get_block_number() RPC calls and means we should probably make a block number service internally to broker sooner rather than later. --------- Co-authored-by: Victor Graf <victor@risczero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Related Issues
Closes #123