Swift: replace getCanonicalPointer with std::variant
#9172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned out easier than expected previously. `llvm::PointerUnion` was also considered, which would have less memory footprint, but it would require more effort as it is lacking the same implicit conversions and operators that `std::variant` provides. Also renamed `ToTag<E>` to `TrapTagOf<E>` and introduced a derived convenience functor `TrapLabelOf<E>`.
sashabu
suggested changes
May 16, 2022
sashabu
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out easier than expected previously.
llvm::PointerUnionwas also considered, which would have less memory footprint, but it
would require more effort as it is lacking the same implicit conversions
and operators that
std::variantprovides.Also renamed
ToTag<E>toTrapTagOf<E>and introduced a derivedconvenience functor
TrapLabelOf<E>.This is a follow-up to #9112