Swift: add structured C++ generated classes #9034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `cppgen`, creating structured C++ classes mirroring QL classes out of `schema.yml`. An example of generated code at the time of this commit can be found [in this gist][1]. [1]: https://gist.github.com/redsun82/57304ddb487a8aa40eaa0caa695048fa Closes github/codeql-c-team#863
Contributor
Author
|
this is on top of #9028, so you should ignore the first commit for now (the trapgen unit tests) |
This indicates a list of optional entries. This is different than simply repeatind entries because of the indexing.
This is so that we can use this in the PoC branch.
This enables codegen to run on the swift PoC branch.
AlexDenisov
previously approved these changes
May 9, 2022
AlexDenisov
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
cppgen, creating structured C++ classes mirroring QL classesout of
schema.yml.An example of generated code at the time of this commit can be found
in this gist.
This also introduces the
?*(repeated optional) type modifier in the schemaspecification. On the dbscheme and QL side, this behaves just like
*, savefor the fact that
getNumberOfXis not generated. On the C++ side, thistranslates to a
vector<optional<X>>type.Closes https://github.com/github/codeql-c-team/issues/863