JS: Fix two missing bits of data flow #8687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
erik-krogh
reviewed
Apr 7, 2022
Comment on lines
423
to
429
| t.start() and | ||
| exists(DataFlow::ClassNode cls | | ||
| cls.getASuperClassNode().getALocalSource() = | ||
| DataFlow::globalVarRef(any(string s | s.matches("HTML%Element"))) and | ||
| result = cls.getAReceiverNode() | ||
| ) | ||
| or |
There was a problem hiding this comment.
How about using ClassNode::getAnInstanceReference(), and placing it in domValueRef() below?
erik-krogh
previously approved these changes
Apr 7, 2022
erik-krogh
approved these changes
Apr 7, 2022
|
Evaluation looks ok |
asgerf
removed
the
Awaiting evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues I found while debugging data flow through a codebase.