JS: Improve support for getters and instance members in API graphs #8602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
asgerf
force-pushed
the
js/api-graph-accessors
branch
from
1147bab to
412f3b0
Compare
asgerf
force-pushed
the
js/api-graph-accessors
branch
2 times, most recently
from
2bd46cd to
c400623
Compare
asgerf
force-pushed
the
js/api-graph-accessors
branch
from
c400623 to
29d21b7
Compare
|
Everything but the last commit was moved to #8791. Will open a new PR with the last commit alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memberedges for that getter.memberedges for the instance members of that class (neither methods nor accessors).For now, this PR does not implement setters, just getters.
I suspect my solution to 2 is too naive and will generate a lot of API graph edges (one for each instance member at every point where the class instance escapes), but we'll see.