Java: Make JumpStmt a proper superclass
#8582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Mar 28, 2022
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| category: fix | |||
There was a problem hiding this comment.
Not really a "fix", but the other categories do not seem to fit much better either. Maybe it should be "feature"?
Marcono1234
commented
Mar 29, 2022
smowton
reviewed
Mar 29, 2022
Marcono1234
force-pushed
the
marcono1234/JumpStmt-superclass
branch
from
ec5d537 to
a93b4ed
Compare
|
Thanks for the feedback; have addressed it and force pushed the changes. |
aschackmull
reviewed
Apr 6, 2022
| @@ -557,13 +557,7 @@ class ThrowStmt extends Stmt, @throwstmt { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We generally try to avoid exposing public abstract classes like this, since subclassing using extends can lead to surprising results. It is better to define the union type explicitly:
Suggested change
| private class JumpStmt_ = @breakstmt or @yieldstmt or @continuestmt; | |
There was a problem hiding this comment.
Good point, thanks! I have implemented your suggestion manually, and added a small comment explaining the rationale; hopefully that is alright.
A bit unrelated, but I have created a #8713 to discuss making implementing abstract classes less error-prone.
Public abstract classes can be error-prone, when users unintentionally implement a new subclass instead of refining the set of existing subclasses.
aschackmull
reviewed
Apr 25, 2022
aschackmull
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8569