Skip to content

C++: Update C++ variable hiding test #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Feb 4, 2022

Structured bindings are now handled better, so the false negative related to structured bindings is now a true positive.

@github-actions github-actions bot added the C++ label Feb 4, 2022
@MathiasVP MathiasVP added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Feb 4, 2022
Structured bindings are now handled better, so the false negative
related to structured bindings is now a true positive.
@jketema jketema force-pushed the structured-bindings-fix branch from e0e79b3 to 46821fe Compare February 10, 2022 10:04
@jketema jketema marked this pull request as ready for review February 10, 2022 10:04
@jketema jketema requested a review from a team as a code owner February 10, 2022 10:04
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit d05dbb2 into github:main Feb 10, 2022
@jketema jketema deleted the structured-bindings-fix branch February 10, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants