python: remove library annotation to clean up QL warnings. #7788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to clean up QL warnings. Should put these in a private module instead?
|
Maybe this should be obvious, but what warnings are we getting for these? (and why?) |
There's a QL-for-QL query that checks for this presence of this annotation. The annotation itself is deprecated (though not to the degree that it actually emits a compiler warning). |
yoff
changed the title
|
I made it also remove the auto-generated annotations. There is a PR to not auto-generate those. |
tausbn
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should put these functions in a private module instead, as indicated by the documentation for
library?