Skip to content

QL: field unused in disjunct #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2022
Merged

QL: field unused in disjunct #7669

merged 2 commits into from
Jun 15, 2022
+31 −20

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 20, 2022 •
edited
Loading

I've found this pattern during a PR review, but the query finds nothing in github/codeql 🎉

@erik-krogh erik-krogh mentioned this pull request Jan 26, 2022
Closed
@erik-krogh erik-krogh force-pushed the fieldUnusedInDisjunct branch from 02caab7 to fb011c3 Compare March 9, 2022 10:46
@erik-krogh erik-krogh marked this pull request as ready for review March 9, 2022 11:35
@erik-krogh erik-krogh requested a review from a team as a code owner March 9, 2022 11:35
@erik-krogh erik-krogh mentioned this pull request Jun 1, 2022
Merged
@github-actions github-actions bot removed the JS label Jun 2, 2022
nickrolfe
nickrolfe approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@nickrolfe nickrolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I see it caught the CP that was fixed in #9157 🚀

@erik-krogh erik-krogh merged commit b24b275 into github:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrolfe nickrolfe nickrolfe approved these changes

Assignees
No one assigned
Labels
QL-for-QL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-krogh @nickrolfe